Close #321. #424
Merged
Close #321. #424
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ChristopherHogan
requested changes
May 26, 2022
test/CMakeLists.txt
Outdated
| @@ -134,7 +134,7 @@ LSAN_OPTIONS=suppressions=${CMAKE_CURRENT_SOURCE_DIR}/data/asan.supp) | |||
| #------------------------------------------------------------------------------ | |||
| add_executable(bo buffer_organizer_test.cc) | |||
| target_link_libraries(bo ${LIBRT} hermes MPI::MPI_CXX | |||
| $<$<BOOL:${HERMES_RPC_THALLIUM}>:thallium>) | |||
| $<$<BOOL:${HERMES_RPC_THALLIUM}>:thallium> glog::glog gflags) | |||
There was a problem hiding this comment.
Why does this test depend on gflags?
| include_directories(${GLOG_INCLUDE_DIRS}) | ||
|
|
||
| # GFLAGS | ||
| find_package(gflags REQUIRED) |
There was a problem hiding this comment.
I would prefer to make gflags an optional dependency, or remove it altogether. I don't use it for anything, and glog works fine without it.
There was a problem hiding this comment.
I think glog depends on gflags.
[ 1%] Building CXX object src/CMakeFiles/hermes.dir/api/bucket.cc.o
[ 2%] Building CXX object adapter/test/stdio/CMakeFiles/stdio_adapter_test.dir/stdio_adapter_test.cpp.o
In file included from /home/runner/work/hermes/hermes/src/api/bucket.h:16,
from /home/runner/work/hermes/hermes/src/api/bucket.cc:13:
/home/runner/work/hermes/hermes/spack/opt/spack/linux-ubuntu20.04-x86_64_v4/gcc-10.3.0/glog-0.4.0-jcohf3eh7cax7d6742d6owabbwdj6464/include/glog/logging.h:86:10: fatal error: gflags/gflags.h: No such file or directory
86 | #include <gflags/gflags.h>
| ^~~~~~~~~~~~~~~~~
compilation terminated.
There was a problem hiding this comment.
You can disable the gflags dependency via cmake. Unfortunately it looks like the glog spack package doesn't expose a variant without gflags. It hard-codes the dependency. I guess we're stuck with it for now.
src/data_placement_engine.cc
Outdated
| std::string var_name {"blob_dst_" + std::to_string(i) + "_" + | ||
| std::to_string(j)}; | ||
| blob_fraction[i][j] = solver.MakeNumVar(0.0, 1, var_name); | ||
| blob_constrt[num_constrts+i]->SetCoefficient(blob_fraction[i][j], 1); | ||
| // total umber of variables = number of blobs * number of targets. |
There was a problem hiding this comment.
'umber' -> 'number'
ChristopherHogan
approved these changes
May 27, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Replace OR-TOOLS with GLPK.