ADAPTER_MODE=SCRATCH deletes bucket after file close, but has no backing file to re-obtain contents #458
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…sets file_size = blob_size in each FS-based adapter.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When running IOR, I noticed that ADAPTER_MODE=SCRATCH causes issues when a file is opened-modified-closed more than once in a single lifetime. This is because ADAPTER_MODE=SCRATCH doesn't store the bucket before it's destroyed. Added a condition in filesystem.cc to ensure that when ADAPTER_MODE=SCRATCH, buckets aren't destroyed when the file is closed.