Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Improving locking logic in the MDM #66

Merged
merged 1 commit into from
Jan 20, 2021
Merged

Improving locking logic in the MDM #66

merged 1 commit into from
Jan 20, 2021

Conversation

ChristopherHogan
Copy link
Collaborator

  • Added HERMES_INVALID_CODE_PATH macro.
  • GetIdsPtr now automatically acquires a lock and requires an accompanying ReleaseIdsPtr call.
  • Tried to improve the way locks are handled in the MDM.

@coveralls
Copy link

Pull Request Test Coverage Report for Build 488534029

  • 158 of 166 (95.18%) changed or added relevant lines in 4 files are covered.
  • 3 unchanged lines in 2 files lost coverage.
  • Overall coverage increased (+0.3%) to 80.461%
Changes Missing Coverage Covered Lines Changed/Added Lines %
src/communication_mpi.cc 0 1 0.0%
src/config_parser.cc 0 1 0.0%
src/metadata_storage_stb_ds.cc 154 160 96.25%
Files with Coverage Reduction New Missed Lines %
src/data_placement_engine.cc 1 95.73%
src/metadata_storage_stb_ds.cc 2 95.84%
Totals Coverage Status
Change from base Build 486540208: 0.3%
Covered Lines: 4225
Relevant Lines: 5251
💛 - Coveralls

@ChristopherHogan ChristopherHogan merged commit b25af17 into master Jan 20, 2021
@ChristopherHogan ChristopherHogan deleted the chogan/lock_ids_ptr branch January 20, 2021 14:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jya-kmu jya-kmu jya-kmu approved these changes

@hariharan-devarajan hariharan-devarajan Awaiting requested review from hariharan-devarajan

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@ChristopherHogan @coveralls @jya-kmu