Send Blobs to swap space on GetBuffers failure #69
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The old behavior sent
Blob
s to swap space whenCalculatePlacement
failed and returned an error whenGetBuffers
failed. Now we do the opposite. Return an error whenCalculatePlacement
fails and send theBlob
to swap space whenGetBuffers
fails. I had to add aForceBlobToSwap
function to the tests because triggering aBlob
to go to swap from the API would require getting lucky with race conditions.