Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Send Blobs to swap space on GetBuffers failure #69

Merged
merged 1 commit into from
Jan 21, 2021

Conversation

ChristopherHogan
Copy link
Collaborator

The old behavior sent Blobs to swap space when CalculatePlacement failed and returned an error when GetBuffers failed. Now we do the opposite. Return an error when CalculatePlacement fails and send the Blob to swap space when GetBuffers fails. I had to add a ForceBlobToSwap function to the tests because triggering a Blob to go to swap from the API would require getting lucky with race conditions.

@coveralls
Copy link

Pull Request Test Coverage Report for Build 498786624

  • 5 of 7 (71.43%) changed or added relevant lines in 2 files are covered.
  • 1 unchanged line in 1 file lost coverage.
  • Overall coverage decreased (-0.03%) to 80.446%

Changes Missing Coverage Covered Lines Changed/Added Lines %
src/api/bucket.cc 1 2 50.0%
src/buffer_pool.cc 4 5 80.0%
Files with Coverage Reduction New Missed Lines %
src/data_placement_engine.cc 1 95.73%
Totals Coverage Status
Change from base Build 498757956: -0.03%
Covered Lines: 4225
Relevant Lines: 5252

💛 - Coveralls

@ChristopherHogan ChristopherHogan merged commit 0cbcb69 into master Jan 21, 2021
@ChristopherHogan ChristopherHogan deleted the chogan/HERM-77 branch January 21, 2021 14:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants