Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Free buffers when overwriting a blob #70

Merged
merged 3 commits into from
Jan 22, 2021
Merged

Conversation

ChristopherHogan
Copy link
Collaborator

  • On a Put, we first need to check if the Bucket already contains the Blob and if so, delete it before replacing it.
  • I added a helper function to test_utils.h that required including bucket.h, so I had to make Thallium available to the tests in test/CMakeList.txt.
  • In ContainsBlob we can return false if the BlobID is NULL.

@coveralls
Copy link

Pull Request Test Coverage Report for Build 501338228

  • 8 of 9 (88.89%) changed or added relevant lines in 2 files are covered.
  • 5 unchanged lines in 2 files lost coverage.
  • Overall coverage decreased (-0.08%) to 80.362%

Changes Missing Coverage Covered Lines Changed/Added Lines %
src/metadata_management.cc 4 5 80.0%
Files with Coverage Reduction New Missed Lines %
src/metadata_management.cc 2 80.67%
src/stb_ds.h 3 65.59%
Totals Coverage Status
Change from base Build 501302093: -0.08%
Covered Lines: 4223
Relevant Lines: 5255

💛 - Coveralls

@ChristopherHogan ChristopherHogan merged commit 748541a into master Jan 22, 2021
@ChristopherHogan ChristopherHogan deleted the chogan/HERM-76 branch January 22, 2021 14:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants