Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds support for authenticating against Google OpenID and potentially other providers. Client support is in HDFGroup/h5pyd#81.
Azure tests should be repeated (I do not have Azure access) and docs need to be updated still.
New settings
openid_provider
- provider to use for OpenID authentication. Valid values areazure
(default) andgoogle
.openid_audience
- The intended audience of the OpenID token. If not set, falls back on theazure_resource_id
variable. For Google, this should be theclient_id
.openid_claims
- List of claims to use when resolving usernames from OpenID token in order of priority. The default is the previously hardcoded Azure settingunique_name,appid
. Neither of these are defined by Google.sub
would be valid for all OpenID configurations, but is opaque and not helpful for setting ACLs.