Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Google OpenID Support #52

Merged
merged 8 commits into from
Apr 8, 2020
Merged

Google OpenID Support #52

merged 8 commits into from
Apr 8, 2020

Conversation

jjaraalm
Copy link

@jjaraalm jjaraalm commented Apr 3, 2020

Adds support for authenticating against Google OpenID and potentially other providers. Client support is in HDFGroup/h5pyd#81.

Azure tests should be repeated (I do not have Azure access) and docs need to be updated still.

New settings

  1. openid_provider - provider to use for OpenID authentication. Valid values are azure (default) and google.
  2. openid_audience - The intended audience of the OpenID token. If not set, falls back on the azure_resource_id variable. For Google, this should be the client_id.
  3. openid_claims - List of claims to use when resolving usernames from OpenID token in order of priority. The default is the previously hardcoded Azure setting unique_name,appid. Neither of these are defined by Google. sub would be valid for all OpenID configurations, but is opaque and not helpful for setting ACLs.

@jreadey jreadey merged commit d74ef81 into HDFGroup:master Apr 8, 2020
@jreadey
Copy link
Member

jreadey commented Apr 8, 2020

Thanks @jjaraalm! This was working for me with AD. I made one change: 6ad25d3 since sometimes the config get evaluates to empty string vs None.

This was referenced Apr 8, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants