Test H5Ovisit on file, nested groups, and attributes #58
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
vol_object_test.c
Outdated
| "/" OBJECT_VISIT_TEST_GROUP_NAME_GRANDCHILD)) { | ||
| (*i)--; | ||
| goto done; | ||
| } |
There was a problem hiding this comment.
I'd suggest rearranging the group hierarchy or even putting the nested groups in the separate new file created so that you don't have to worry about decrementing the counter here in other unrelated parts of the H5Ovisit test. That way the two different parts aren't dependent on each other and won't get out of sync and require more strcmp logic here if more nested groups are added.
vol_object_test.c
Outdated
| H5Fdelete(filename, H5P_DEFAULT); | ||
|
|
||
| HDsnprintf(filename, VOL_TEST_FILENAME_MAX_LENGTH, "%s%s", test_path_prefix, OBJECT_VISIT_TEST_FILE_NAME); | ||
| H5Fdelete(OBJECT_VISIT_TEST_FILE_NAME, H5P_DEFAULT); |
There was a problem hiding this comment.
Should be filename instead of OBJECT_VISIT_TEST_FILE_NAME
jhendersonHDF
approved these changes
Jan 10, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.