Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Create box cox transformer #15

Merged
merged 23 commits into from
Dec 20, 2018
Merged

Create box cox transformer #15

merged 23 commits into from
Dec 20, 2018

Conversation

kelvin-lu
Copy link
Contributor

Creates a box cox transformer that fits according to boxcox1p (boxcox(x+1).

micahjsmith
micahjsmith requested changes Oct 16, 2018
View reviewed changes
Copy link
Contributor

@micahjsmith micahjsmith left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for adding!

ballet/eng/misc.py Outdated Show resolved Hide resolved
ballet/eng/misc.py Outdated Show resolved Hide resolved
ballet/eng/misc.py Outdated Show resolved Hide resolved
ballet/eng/misc.py Outdated Show resolved Hide resolved
ballet/eng/misc.py Outdated Show resolved Hide resolved
ballet/eng/misc.py Outdated Show resolved Hide resolved
@micahjsmith
Copy link
Contributor

micahjsmith commented Nov 12, 2018 •
edited
Loading

One more fix above needed, then documentation and tests as well. Finally, CI tests should pass.

For tests:

  • move tests.eng.test_base.TestMisc into a new file, tests/eng/test_misc.py
  • add and implement an additional method test_box_cox_transformer

micahjsmith
micahjsmith requested changes Nov 15, 2018
View reviewed changes
ballet/eng/misc.py Outdated Show resolved Hide resolved
ballet/eng/misc.py Show resolved Hide resolved
ballet/eng/misc.py Show resolved Hide resolved
tests/eng/test_misc.py Outdated Show resolved Hide resolved
@kelvin-lu
Copy link
Contributor Author

Thanks Micah! These look good to me

@kelvin-lu kelvin-lu closed this Dec 20, 2018
@kelvin-lu kelvin-lu deleted the kelvin-skew-boxcox branch December 20, 2018 21:28
@kelvin-lu kelvin-lu restored the kelvin-skew-boxcox branch December 20, 2018 21:28
@kelvin-lu kelvin-lu reopened this Dec 20, 2018
@kelvin-lu kelvin-lu merged commit 8a393b7 into master Dec 20, 2018
@kelvin-lu kelvin-lu deleted the kelvin-skew-boxcox branch December 20, 2018 21:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@micahjsmith micahjsmith micahjsmith approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@kelvin-lu @micahjsmith