Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

(Fix) Use separate capture groups instead of negative look-behind #1196

Merged
merged 1 commit into from
Mar 3, 2020
Merged

(Fix) Use separate capture groups instead of negative look-behind #1196

merged 1 commit into from
Mar 3, 2020

Conversation

werrpy
Copy link
Contributor

@werrpy werrpy commented Mar 3, 2020

This re-writes the regex to use separate capture groups for each case, instead of negative look-ahead. Tested by defining the function in a firefox console on a new tab

@codecov
Copy link

codecov bot commented Mar 3, 2020

Codecov Report

Merging #1196 into master will decrease coverage by 0.91%.
The diff coverage is n/a.

Impacted file tree graph

@@             Coverage Diff              @@
##             master    #1196      +/-   ##
============================================
- Coverage     23.66%   22.74%   -0.92%     
  Complexity     4140     4140              
============================================
  Files           296      296              
  Lines         13109    13109              
============================================
- Hits           3102     2982     -120     
- Misses        10007    10127     +120
Impacted Files Coverage Δ Complexity Δ
app/Services/Data/Person.php 0% <0%> (-87.5%) 7% <0%> (ø)
app/Services/Data/Genre.php 0% <0%> (-60%) 7% <0%> (ø)
app/Services/Clients/TmdbClient.php 5.52% <0%> (-42.86%) 89% <0%> (ø)
app/Services/Clients/Client.php 60% <0%> (-26.67%) 15% <0%> (ø)
app/Services/Data/Movie.php 17.46% <0%> (-15.88%) 40% <0%> (ø)
app/Http/Controllers/API/TorrentController.php 70.14% <0%> (-2.49%) 83% <0%> (ø)
app/Helpers/StringHelper.php 13.72% <0%> (-1.97%) 41% <0%> (ø)
app/Http/Controllers/AnnounceController.php 46.3% <0%> (ø) 65% <0%> (ø) ⬇️
app/Models/User.php 37.3% <0%> (+3.17%) 122% <0%> (ø) ⬇️
app/Services/MovieScrapper.php 61.11% <0%> (+5.55%) 10% <0%> (ø) ⬇️
... and 1 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 3edcc96...6737fc6. Read the comment docs.

@werrpy
Copy link
Contributor Author

werrpy commented Mar 3, 2020

#1192, #1193

@HDVinnie
Copy link
Collaborator

HDVinnie commented Mar 3, 2020

Close #1192 #1193

@HDVinnie HDVinnie merged commit 1b09be3 into HDInnovations:master Mar 3, 2020
@HDVinnie
Copy link
Collaborator

HDVinnie commented Mar 3, 2020

@werrpy upon further testing this doesn't appear to fix support for Firefox and Safari.

HDVinnie added a commit that referenced this pull request Mar 3, 2020
- PR #1188 and #1196 were not compadable with safari and chrome
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants