Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

(Fix) atomic counter updates in SubtitleController #1430

Merged
merged 1 commit into from
Aug 31, 2020

Conversation

howardlau1999
Copy link
Contributor

It is recommended to use increment method of an object to update counter values to avoid concurrency bugs.

@howardlau1999 howardlau1999 changed the title fix: atomic counter updates in SubtitleController (Fix) atomic counter updates in SubtitleController Aug 31, 2020
@codecov
Copy link

codecov bot commented Aug 31, 2020

Codecov Report

Merging #1430 into master will decrease coverage by 0.80%.
The diff coverage is 0.00%.

Impacted file tree graph

@@             Coverage Diff              @@
##             master    #1430      +/-   ##
============================================
- Coverage     26.97%   26.17%   -0.81%     
  Complexity     4278     4278              
============================================
  Files           305      305              
  Lines         13538    13537       -1     
============================================
- Hits           3652     3543     -109     
- Misses         9886     9994     +108     
Impacted Files Coverage Δ Complexity Δ
app/Http/Controllers/SubtitleController.php 0.00% <0.00%> (ø) 23.00 <0.00> (ø)
app/Services/Data/Person.php 0.00% <0.00%> (-87.50%) 7.00% <0.00%> (ø%)
app/Services/Data/Genre.php 0.00% <0.00%> (-60.00%) 7.00% <0.00%> (ø%)
app/Services/Clients/TmdbClient.php 6.91% <0.00%> (-45.63%) 90.00% <0.00%> (ø%)
app/Services/Clients/Client.php 62.06% <0.00%> (-24.14%) 15.00% <0.00%> (ø%)
app/Services/Data/Movie.php 17.46% <0.00%> (-15.88%) 40.00% <0.00%> (ø%)
app/Http/Controllers/API/TorrentController.php 60.81% <0.00%> (-1.23%) 111.00% <0.00%> (ø%)
app/Http/Controllers/AnnounceController.php 45.27% <0.00%> (ø) 66.00% <0.00%> (ø%)
app/Models/User.php 40.47% <0.00%> (+0.39%) 122.00% <0.00%> (ø%)
app/Http/Controllers/CommentController.php 77.37% <0.00%> (+1.45%) 46.00% <0.00%> (ø%)
... and 4 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 8ce622d...d881905. Read the comment docs.

@HDVinnie HDVinnie merged commit 27f56f8 into HDInnovations:master Aug 31, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants