Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

(Update) use peer id for client blacklist instead of user agent #2828

Merged
merged 1 commit into from
Jan 3, 2024

Conversation

Roardom
Copy link
Collaborator

@Roardom Roardom commented Jun 17, 2023

Maybe should just check both and add an extra column in the db.

@what-the-diff
Copy link

what-the-diff bot commented Jun 17, 2023

PR Summary

  • Optimized checkClient function
    The checkClient function now uses a more efficient loop (foreach) instead of the older in_array method, improving performance.
  • Introduction of peerId variable
    A new variable, called $peerId, is created to store the peer id from the request query string.
  • Enhanced client validation
    The PR enhances the client validation process by checking for any part of the peer id matching with a blacklisted client. If a match is found, a TrackerException 128 (client blacklisted) is thrown.

@Roardom Roardom force-pushed the client-blacklist branch 5 times, most recently from c981188 to b51705e Compare December 30, 2023 09:59
@Roardom Roardom marked this pull request as ready for review December 30, 2023 10:02
@HDVinnie HDVinnie merged commit b544437 into HDInnovations:7.x.x Jan 3, 2024
5 checks passed
@HDVinnie HDVinnie deleted the client-blacklist branch January 3, 2024 04:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants