Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bencode #29

Merged
merged 4 commits into from Dec 13, 2017
Merged

Bencode #29

merged 4 commits into from Dec 13, 2017

Conversation

ghost
Copy link

@ghost ghost commented Dec 13, 2017

This will make the bencode decoder more robust and stable. Some
functionality is now split in seperate functions.

Hyleus added 3 commits December 13, 2017 13:26
This commit will make the bencode decoder more robust and stable. Some
functionality is now split in seperate functions.
@HDVinnie HDVinnie requested a review from a team December 13, 2017 15:02
Copy link
Collaborator

@HDVinnie HDVinnie left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks fine to me. As long as the other core-dev are ok with the changes and using polycast package I vote yes on approving.

@poppabear8883
Copy link
Contributor

in Resolve conflicts you are actually removing psr-2 coding styles, its fine but moving forward for style changes be sure to pay attention to those. Not a big deal tho. Everything else looks functional without any obvious concerns. Good work @Hyleus

@HDVinnie HDVinnie merged commit 4099f66 into HDInnovations:master Dec 13, 2017
@gmunday2 gmunday2 mentioned this pull request Jul 27, 2020
@ghost ghost mentioned this pull request Apr 14, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants