Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

(Update) Cast int announce query parameters to ints #2989

Merged
merged 1 commit into from
Jan 2, 2024

Conversation

Roardom
Copy link
Collaborator

@Roardom Roardom commented Jul 30, 2023

No description provided.

@what-the-diff
Copy link

what-the-diff bot commented Aug 4, 2023

PR Summary

  • Improved Data Accuracy
    This PR includes important updates to our AnnounceController.php and ProcessAnnounce.php files to ensure more accurate data capture and processing. By adding type casting to (int) to several fields, we're making sure that the info we capture and use are numbers, avoiding potential errors or misinterpretations in our calculations.

  • Strict Equality Comparisons
    We have made our code more precise by changing equality comparisons (==) to strict equality comparisons (===) in various places. This means we're not just comparing values, but the actual type of the information - ensuring that, for example, the string '5' is not considered the same as the number 5. This increases overall reliability.

  • Improved User Download Verification
    Changes were made to enhance the checks over users' download permissions. With this modification, only users with explicit download rights will be able to initiate downloads thus providing better control.

These updates are part of our continuous efforts to improve the internals of our platform, making it more robust, more secure, and more reliable.

@Roardom Roardom reopened this Jan 1, 2024
@HDVinnie HDVinnie merged commit 81f45ab into HDInnovations:7.x.x Jan 2, 2024
5 checks passed
@HDVinnie HDVinnie deleted the cast-announce-ints branch January 2, 2024 01:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants