(Add) Ip blocking system #3136
Merged
(Add) Ip blocking system #3136
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Roardom
reviewed
Sep 12, 2023
| { | ||
| Schema::create('blocked_ips', function (Blueprint $table): void { | ||
| $table->id(); | ||
| $table->unsignedInteger('user_id'); |
There was a problem hiding this comment.
Probably should block ranges instead of IPs directly. Blocked IPs aren't always associated with a user, so the user_id should be nullable as well.
There was a problem hiding this comment.
So the user_id here is not related to a blocked member but is just to show what staff member initiated the block on said IP.
There was a problem hiding this comment.
Ah, that makes sense. Ranges would still be useful however if easy enough.
There was a problem hiding this comment.
Wildcards would be nice also. xxx.xxx.xxx.* for instance, to block the /24
Co-authored-by: Roardom <78790963+Roardom@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.