Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

(Fix) Json serialization in database migrations #3184

Merged

Conversation

Roardom
Copy link
Collaborator

@Roardom Roardom commented Oct 15, 2023

When the switch was made in the database migrations to use the query builder instead of eloquent models in e67f7dc, the json casting provided by the eloquent models weren't accounted for. We have to deserialize and serialize the json manually now.

When the switch was made in the database migrations to use the query builder instead of eloquent models in e67f7dc, the json casting provided by the eloquent models weren't accounted for. We have to deserialize and serialize the json manually now.
@what-the-diff
Copy link

what-the-diff bot commented Oct 15, 2023

PR Summary

  • Update to User Notifications Table
    This change offers a new function named $migrate which transforms input and output formats more efficiently. This function is now utilized within a loop in the code, making the processing of each 'field' smoother and more systematic.

  • Enhancements in User Privacy Table
    Similarly, the User Privacy Table has also seen improvements. A similar $migrate function was introduced to streamline the input-output format conversion. This upgraded function is now used within a loop, thus making the handling of each 'field' more efficient and organized.

@HDVinnie HDVinnie merged commit 7a5fc9d into HDInnovations:7.x.x Oct 15, 2023
4 checks passed
@HDVinnie HDVinnie deleted the fix-json-serialization-in-migrations branch October 15, 2023 14:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants