Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

(Fix) Requests filled with soft deleted torrents #3220

Merged
merged 1 commit into from
Nov 6, 2023

Conversation

Roardom
Copy link
Collaborator

@Roardom Roardom commented Nov 5, 2023

No description provided.

Copy link

what-the-diff bot commented Nov 5, 2023

PR Summary

  • Refined condition checks in show.blade.php
    The conditions in this file related to torrentRequest were checked on torrent_id. It's now updated to check directly on torrent. This makes the conditions more meaningful as they can check the existence of a torrent instead of just its ID.

  • Improved conditions with claim check
    Several lines in the code involved checking for both a torrent and a claim using claim !== null. These conditional checks were refined to directly consider the existence of a torrent, making the checks more precise. These changes were applied consistently across the file, enhancing code readability and maintainability.

These updates make the file's code more effective at checking required conditions, potentially reducing errors and increasing application stability.

@HDVinnie HDVinnie merged commit 9569ed5 into HDInnovations:7.x.x Nov 6, 2023
4 checks passed
@HDVinnie HDVinnie deleted the fix-request-deleted-torrent branch November 6, 2023 14:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants