Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

(Add) Refundable option to API #3556

Merged
merged 1 commit into from
Mar 9, 2024

Conversation

Obi-Wana
Copy link
Contributor

Allows to:

  • Set refundable on upload
  • Query API for refundable uploads
  • Query API for non-refundable uploads

Allows to select or deselect refundable. If refundable is not added to GET requests, it will be ignored.

@Roardom
Copy link
Collaborator

Roardom commented Feb 22, 2024

Do you know if the refund code even works? (#3393)

@Obi-Wana
Copy link
Contributor Author

Do you know if the refund code even works? (#3393)

@Roardom I don't know, I was not aware of any issues with the refundable code itself.

Copy link
Collaborator

@Roardom Roardom left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It should just be ->refundable() like the other boolean flags. You can find the documentation for local scopes here: https://laravel.com/docs/10.x/eloquent#local-scopes

@Roardom
Copy link
Collaborator

Roardom commented Mar 2, 2024

I should have made it more clear. The torrent search page already uses the ->refundable() scope, so you can't rename it. If you want to offer this functionality of being able to search when it's false as well, you have to make a new scope instead of renaming the existing one.

@Obi-Wana Obi-Wana requested a review from Roardom March 5, 2024 15:14
Copy link
Collaborator

@Roardom Roardom left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Dropped the latest commit and squashed the remaining ones 👍

@HDVinnie HDVinnie merged commit fd18f48 into HDInnovations:7.x.x Mar 9, 2024
5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants