(Fix) Broken bookmarks button #3859
Conversation
|
Nevermind, the bug is triggered by selecting a couple of filters, and then bookmarks look like this...
This doesn't look like an easy fix... |
Roardom
force-pushed
the
re-enable-bookmarks
branch
from
fcd02fa
to
5858e8f
Compare
This must have been broken for a long time. This also fixes the issue when ticking checkboxes too quickly the state being reset. It required both making sure `small-bookmark-button.blade.php` was surrounded by an element completely, as well as adding wire:key to the inner row loop. Adding wire:key to the component itself doesn't work because the attributes aren't passed through...
Roardom
force-pushed
the
re-enable-bookmarks
branch
from
5858e8f
to
b5fccaa
Compare
|
Figured it out. |
Roardom
changed the title
|
Does this mess with selecting torrents to be deleted in the similar view? |
I selected a few torrents in similar view rapidly and got no errors in the console. Is there something specific you want me to check for? |
It broke for me, but i have an altered similar page so its probably just my fault then. No worries then. all good :) |
|
That's exactly the error the bookmark button was causing. Go through every loop in your blade and add a |
|
Seems like there are still issues with this. I have the same issue on my install. Happends when searching for torrents. |
BLU small bookmark seems fine for me. It was just updated to latest v8 branch and there hasn't been a new release so fresh install wouldn't have it. |
Sent a dm on discord with a video. |
|
@Roardom @LostRager is correct. Still broken. Seems to happen when searching by name |
|
😞 I'll try and figure this out |
|
@LostRager After a ridiculously long time spent debugging, I've discovered that removing component not found error from the console (at least in my local setup).
The only way I was able to trigger that error was by typing ~5-10 characters in the name field, at a frequency slower than the 250ms debounce but fast enough that the previous search hadn't returned results yet. Do you mind trying that out and see if that works for you? I found triggering the |
Seems like the issue |
|
Glad to hear! Also should note: it appears that it will still break if you have view cache enabled. We need to both remove x-cloak as well as clear view cache to remove these console errors. |
|
Wonder what broke or changed from livewire 2 to livewire 3 to not make it work anymore. |
|
Found this: livewire/livewire#5658 Which seems to align with what I'm seeing. |
This must have been broken for a long time. This also fixes the issue when ticking checkboxes too quickly the state being reset. It required both making sure
small-bookmark-button.blade.phpwas surrounded by an element completely, as well as adding wire:key to the inner row loop. Adding wire:key to the component itself doesn't work because the attributes aren't passed through...