Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Namespace Models #594

Merged
merged 2 commits into from
Feb 22, 2019
Merged

Namespace Models #594

merged 2 commits into from
Feb 22, 2019

Conversation

HDVinnie
Copy link
Collaborator

This pull request includes changes for namespacing models under App\Models. Feel free to commit any additional changes to the shift-12081 branch.

Before merging, you should:

  • Checkout the shift-12081 branch
  • Review all pull request comments for additional changes
  • Thoroughly test your application

@laravel-shift
Adopt PSR-2 coding style
12397c9 
The Laravel framework adopts the PSR-2 coding style in version 5.1.
Laravel apps *should* adopt this coding style as well. Read the
[PSR-2 coding style guide][1] for more details and check out [PHPCS][2]
to use as a code formatting tool.

[1]: https://github.com/php-fig/fig-standards/blob/master/accepted/PSR-2-coding-style-guide.md
[2]: https://github.com/squizlabs/PHP_CodeSniffer
@laravel-shift
Namespace models under App\Models
46ddd8b
@HDVinnie
Copy link
Collaborator Author

⚠️ While Shift updated model references within your application code, you may reference models outside the code. Be sure to review your environment configuration, database, and queues for additional references.

@HDVinnie HDVinnie merged commit dd158f0 into master Feb 22, 2019
@HDVinnie HDVinnie deleted the shift-12081 branch February 22, 2019 03:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@HDVinnie @laravel-shift