Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix for MediaInfo stuff. Helper works! But View has to be tested (!) #69

Merged
merged 7 commits into from Dec 22, 2017

Conversation

TomArrow
Copy link
Contributor

@TomArrow TomArrow commented Dec 22, 2017

Did test the MediaInfo helper with a local script, but I don't have the environment for the whole Laravel thing, so someone will have to test whether the view works as it is. I didn't get any syntax errors, so I hope there won't be any major issues.

Changed up a couple of things, like adding the "title" property to the display and changing "codec" to "format" for subtitles (because it doesn't work well for m2ts files).

Also, I removed the blanket strtolower and added it where it was necessary (to section and property recognition and some of the property parsers). The upside of this is that a lot of MediaInfo information that uses both uppercase and lowercase is now fixed.

Added a shitton of security tests for non-existent properties etc. (both in view and helper), so there should be no more exceptions.

@HDVinnie
Copy link
Collaborator

thanks ill review this today when home before pushing and double check to make sure all works.

@TomArrow
Copy link
Contributor Author

TomArrow commented Dec 22, 2017 via email

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants