Ig 767 #196
Ig 767 #196
Conversation
…e approved and rejected status
CiaraWardPA
requested review from
AlexPowerPA,
CMarksPA,
PaulMcCaffertyPA,
RichardHobbsPA,
RobinKavPA and
tonyespley-pa
src/resources/stats/kpis.router.js
Outdated
| {"applicationStatus":"submitted"}, | ||
| {"applicationStatus":"approved"}, | ||
| {"applicationStatus":"rejected"} |
There was a problem hiding this comment.
There are a couple of other application statuses that I assume we want to detect here, 'inProgress' and 'approved with conditions'. The only one I assume we want to filter out is 'withdrawn' so you could just change it to NOT withdrawn?
There was a problem hiding this comment.
Is 'inProgress' an application in progress prior to being submitted? We only want from submitted and after, so I should probably update to add in a check for 'approved with conditions'
There was a problem hiding this comment.
That's correct, then just 'approved with conditions'
src/resources/stats/kpis.router.js
Outdated
| console.log(`selectedMonthStart - ${selectedMonthStart}`) | ||
| console.log(`selectedMonthEnd - ${selectedMonthEnd}`) |
There was a problem hiding this comment.
Should remove console logs, but could in future use Moment to format the date passed in, which would save a few lines of code
There was a problem hiding this comment.
@RobinKavPA @CiaraWardPA It could be something like this, depending on the passed in params you could do this....
moment('01/04/2021').startOf('month').format("DD/MM/YYYY 00:00:000");
"01/04/2021 00:00:000"
moment('18/04/2021').endOf('month').format("DD/MM/YYYY 23:59:59");
"31/04/2021 23:59:59"
There was a problem hiding this comment.
Console logs removed
No description provided.