Removed Admins ability to opt out of emails to do with approving tool… #201
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…s/projects/papers and courses. Also fixed courses emails that were not sending to regular users.
RichardHobbsPA
requested review from
PaulMcCaffertyPA,
RobinKavPA,
CiaraWardPA and
CMarksPA
RobinKavPA
reviewed
Nov 11, 2020
|
Line 326 seems ok to me? // 3. Find the creator of the course if they have opted in to email updates We don't appear to send out an email for the approval of a collection as collections have a status of active upon creation. |
|
Cool on collections, with regards to 326, I was thinking it could state creator and admins of the system as your Mongo query is getting all admins too. |
RobinKavPA
approved these changes
Nov 12, 2020
CiaraWardPA
approved these changes
Nov 12, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
…s/projects/papers and courses. Also fixed courses emails that were not sending to regular users.