Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Implement cleanup for expired recoveryfiles #24

Closed
jimboid opened this issue Jan 12, 2017 · 0 comments
Closed

Implement cleanup for expired recoveryfiles #24

jimboid opened this issue Jan 12, 2017 · 0 comments
Assignees
Milestone

Comments

@jimboid
Copy link
Member

jimboid commented Jan 12, 2017

Recovery files tend to build up rapidly over time, currently the user has to periodically clean these out by themselves. A better solution would be either of:

  1. Only keep a small number (say the last week)
  2. Provide a command-line flag such as --recovery-clean and just wipe out anything in the directory with it.
  3. Rearrange how the file is handled within the code. Use the global jobfile parameter simply for initial creation. Then store a handle to the file under each job (no other place to put it). This way can make use of the filename throughout Longbow, no need to create new recovery file on recovery or reconnections and can add code to the cleanup function to kill the recovery file once all jobs are done.
@jimboid jimboid added this to the v1.4.1 milestone Jan 12, 2017
@jimboid jimboid self-assigned this Jan 12, 2017
jimboid added a commit that referenced this issue Jun 7, 2017
Preparations for adding the cleanup code. This involved making the
recovery file name accessable outside of the scheduling module.

To accomplish this, the "recoveryfile" parameter was added to the
default data structure "jobs" this is initialised during the
configuration steps of Longbow. Unit tests were updated and some new
tests added to retain coverage and test new functionality.
jimboid added a commit that referenced this issue Jun 7, 2017
The remove recovery file code has now been added along with some unit
tests for it.
@jimboid jimboid mentioned this issue Jun 7, 2017
jimboid added a commit that referenced this issue Jun 7, 2017
@jimboid jimboid closed this as completed Jun 7, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

1 participant