Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[FEATURE] Add support for friend link shortcode #31

Merged
merged 8 commits into from
Apr 30, 2021

Conversation

HEIGE-PCloud
Copy link
Owner

  • Add friend link shortcode template
  • Add friend link shortcode stylesheet
  • Add documentation for friend link shortcode
  • Add test page for friend link shortcode

Many thanks to this page.

- Add friend link shortcode template
- Add friend link shortcode stylesheet
- Add documentation for friend link shortcode
- Add test page for friend link shortcode
@HEIGE-PCloud HEIGE-PCloud added documentation Improvements or additions to documentation enhancement Enhance existing features labels Apr 29, 2021
@HEIGE-PCloud HEIGE-PCloud added this to the v0.2.11 milestone Apr 29, 2021
@HEIGE-PCloud HEIGE-PCloud self-assigned this Apr 29, 2021
@HEIGE-PCloud HEIGE-PCloud added this to In progress in Roadmap via automation Apr 29, 2021
@cloudflare-pages
Copy link

cloudflare-pages bot commented Apr 29, 2021

Deploying with  Cloudflare Pages  Cloudflare Pages

Latest commit: a673875
Status: ✅  Deploy successful!
Preview URL: https://776ed259.hugodoit.pages.dev

View logs

@HEIGE-PCloud HEIGE-PCloud changed the title feat: Add support for friend link shortcode [FEATURE] Add support for friend link shortcode Apr 29, 2021
@HEIGE-PCloud HEIGE-PCloud linked an issue Apr 29, 2021 that may be closed by this pull request
@HEIGE-PCloud
Copy link
Owner Author

HEIGE-PCloud commented Apr 29, 2021

Check this page for preview.

@HEIGE-PCloud

This comment has been minimized.

Roadmap automation moved this from In progress to Reviewer approved Apr 29, 2021
SpongeBab
SpongeBab previously approved these changes Apr 29, 2021
- Add global author setting
- Remove test pages from home page
Roadmap automation moved this from Reviewer approved to Review in progress Apr 29, 2021
layouts/shortcodes/friend.html Outdated Show resolved Hide resolved
layouts/shortcodes/friend.html Outdated Show resolved Hide resolved
@HEIGE-PCloud
Copy link
Owner Author

@SpongeBab Review is not something that I click review request, you click approved then everything is fine and call it a day. Identifying bugs and issues at the pull request stage is much better than merging bugs into production and then open a new issue to fix it. I check my code today and very luckily fix the issue before clicking Rebase and merge, but I may fail to do that in future pull requests. I hope the reviews and approves can be more useful and have some real feedback. Many thanks.

@SpongeBab
Copy link
Contributor

SpongeBab commented Apr 30, 2021 via email

@HEIGE-PCloud HEIGE-PCloud merged commit 2ad853b into main Apr 30, 2021
Roadmap automation moved this from Review in progress to Done Apr 30, 2021
@HEIGE-PCloud HEIGE-PCloud deleted the dev/friend-link-shortcode branch April 30, 2021 08:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
documentation Improvements or additions to documentation enhancement Enhance existing features
Projects
No open projects
Roadmap
  
Done
Development

Successfully merging this pull request may close these issues.

A possible friend links layout
2 participants