Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor: keep improving theme.js #395

Merged
merged 6 commits into from
Dec 19, 2021
Merged

refactor: keep improving theme.js #395

merged 6 commits into from
Dec 19, 2021

Conversation

HEIGE-PCloud
Copy link
Owner

No description provided.

@HEIGE-PCloud HEIGE-PCloud added the enhancement Enhance existing features label Dec 16, 2021
@HEIGE-PCloud HEIGE-PCloud added this to the v0.2.14 milestone Dec 16, 2021
@HEIGE-PCloud HEIGE-PCloud self-assigned this Dec 16, 2021
@HEIGE-PCloud HEIGE-PCloud added this to In progress in Roadmap via automation Dec 16, 2021
@vercel
Copy link

vercel bot commented Dec 16, 2021

This pull request is being automatically deployed with Vercel (learn more).
To see the status of your deployment, click below or on the icon next to each commit.

🔍 Inspect: https://vercel.com/pcloud/do-it/Bopnj2TQbXvc9upW4JepWdoJvM79
✅ Preview: https://do-it-git-refactor-js-pcloud.vercel.app

@HEIGE-PCloud HEIGE-PCloud linked an issue Dec 16, 2021 that may be closed by this pull request
2 tasks
@HEIGE-PCloud
Copy link
Owner Author

The cdn config will be refactored in to a different format, containing the version information and path in different arguments (and gets processed later in init.html) so a script can be used to fetch and update all files automatically.

Related:
https://github.com/HEIGE-PCloud/DoIt/blob/5952033e29adf6277b45bd6eb7832037efdd77da/layouts/partials/init.html#L16-25

@HEIGE-PCloud HEIGE-PCloud enabled auto-merge (squash) December 19, 2021 20:32
@HEIGE-PCloud HEIGE-PCloud merged commit 3f04d3f into main Dec 19, 2021
Roadmap automation moved this from In progress to Done Dec 19, 2021
@HEIGE-PCloud HEIGE-PCloud deleted the refactor/js branch December 19, 2021 20:33
@HEIGE-PCloud
Copy link
Owner Author

Just decide to merge this first and I will start working on migrating all comment systems on a seperate pr.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement Enhance existing features
Projects
No open projects
Roadmap
  
Done
Development

Successfully merging this pull request may close these issues.

[Enhancement] Refactor theme.js
1 participant