optimize: improve toc performance #402
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
By replacing getBoundingClientRect to offsetTop, the function execution time has been reduced signifficantly. The removal of legacy states are moved to the end so no forced reflow is created which improves the performance as well. There is an unsolved bug that it cannot handle the last heading activation and needs more debugging.
|
This pull request is being automatically deployed with Vercel (learn more). 🔍 Inspect: https://vercel.com/pcloud/do-it/3EpFfnCTRZff2WxWL9b89ByaFecp |
|
Have to say that the refactoring makes the development on theme.js a lot easier :) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
By replacing
getBoundingClientRecttooffsetTop, the function execution time has been reduced significantly. The removal of legacy states is moved to the end so no forced reflow is created which improves the performance as well.It cannot handle the last heading activation currently and needs more debugging.Close #382