Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(scrollbar): use $custom-scrollbar var in table wrapper #555

Merged
merged 2 commits into from
Apr 5, 2022

Conversation

rolandjitsu
Copy link
Contributor

It looks like the use of $custom-scrollbar was omitted for the table wrapper. This results in a small visual bug on macOS 11.6/Chrome 99.0.

Before (notice the small white rectangle at the bottom right):

Screenshot 2022-04-04 at 21 01 19

After:

Screenshot 2022-04-04 at 21 05 25

@vercel
Copy link

vercel bot commented Apr 4, 2022

Someone is attempting to deploy a commit to a Personal Account owned by @HEIGE-PCloud on Vercel.

@HEIGE-PCloud first needs to authorize it.

@vercel
Copy link

vercel bot commented Apr 4, 2022

This pull request is being automatically deployed with Vercel (learn more).
To see the status of your deployment, click below or on the icon next to each commit.

🔍 Inspect: https://vercel.com/pcloud/do-it/H11E8hjECejqFSyDMYMmzwUzhhog
✅ Preview: https://do-it-git-fork-rolandjitsu-main-pcloud.vercel.app

Copy link
Owner

@HEIGE-PCloud HEIGE-PCloud left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The white box still exists when there are both x-overflow and y-overflow.

image

See https://do-it-git-fork-rolandjitsu-main-pcloud.vercel.app/theme-documentation-basics/#site-configuration

I found a possible solution:

https://stackoverflow.com/questions/35968553/webkit-scrollbar-css-always-a-white-box-in-corner

Maybe adding a ::-webkit-scrollbar-corner {background-color: $some_color;} will help?

@HEIGE-PCloud HEIGE-PCloud self-requested a review April 4, 2022 13:16
@rolandjitsu
Copy link
Contributor Author

@HEIGE-PCloud ah, ok. I was using custom scroll bar set to false. So it was gone. Yes, that makes sense. Let me add that.

Copy link
Owner

@HEIGE-PCloud HEIGE-PCloud left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sorry for the delay, it looks good to me now! Thanks! 😸

@HEIGE-PCloud HEIGE-PCloud merged commit a99464b into HEIGE-PCloud:main Apr 5, 2022
@rolandjitsu
Copy link
Contributor Author

Sorry for the delay, it looks good to me now! Thanks! 😸

No worries. Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants