-
-
Notifications
You must be signed in to change notification settings - Fork 192
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix(scrollbar): use $custom-scrollbar var in table wrapper #555
Conversation
Someone is attempting to deploy a commit to a Personal Account owned by @HEIGE-PCloud on Vercel. @HEIGE-PCloud first needs to authorize it. |
This pull request is being automatically deployed with Vercel (learn more). 🔍 Inspect: https://vercel.com/pcloud/do-it/H11E8hjECejqFSyDMYMmzwUzhhog |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The white box still exists when there are both x-overflow and y-overflow.
I found a possible solution:
https://stackoverflow.com/questions/35968553/webkit-scrollbar-css-always-a-white-box-in-corner
Maybe adding a ::-webkit-scrollbar-corner {background-color: $some_color;}
will help?
@HEIGE-PCloud ah, ok. I was using custom scroll bar set to false. So it was gone. Yes, that makes sense. Let me add that. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Sorry for the delay, it looks good to me now! Thanks! 😸
No worries. Thanks! |
It looks like the use of
$custom-scrollbar
was omitted for the table wrapper. This results in a small visual bug on macOS 11.6/Chrome 99.0.Before (notice the small white rectangle at the bottom right):
After: