Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

remove empty string handling #50

Merged
merged 2 commits into from May 22, 2020
Merged

remove empty string handling #50

merged 2 commits into from May 22, 2020

Conversation

ojii
Copy link
Contributor

@ojii ojii commented May 20, 2020

Fixes #48, removes special handling for empty strings and bytes.

Sadly, DynamoDB emulators seem to not yet support this so tests are marked as xfail for now.

@dimaqq
Copy link
Contributor

dimaqq commented May 21, 2020

Document that empty strings are now supported:

  • changelog
  • exception that's no longer raised, if we had such

@dimaqq dimaqq mentioned this pull request May 22, 2020
Closed
@ojii ojii marked this pull request as ready for review May 22, 2020 02:14
@ojii ojii merged commit fdf02bd into master May 22, 2020
@ojii ojii deleted the support-empty-strings branch May 22, 2020 02:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dimaqq dimaqq dimaqq approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Support empty strings
2 participants
@ojii @dimaqq