Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add google chrome device emulation recipe to docs #110

Merged
merged 1 commit into from
Jan 12, 2021
Merged

Conversation

konstunn
Copy link
Contributor

No description provided.

@konstunn konstunn changed the title #79: add google chrome device emulation recipe to docs Add google chrome device emulation recipe to docs Dec 16, 2020
Copy link
Contributor

@dimaqq dimaqq left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Fine by me.

I think @ojii prefers literal dicts like {"args": [...]} but that's minor.

@dimaqq
Copy link
Contributor

dimaqq commented Dec 16, 2020

I've no clue why the "remote" (browserstack) tests suddenly fail...
I've had partial failure in my PR too, but that succeeded on retry; here I'm baffled.

(also I'm a bit confused by circle ci, where I am not allowed to rerun the build for this fork... I think the core reason for both is that browserstack credentials are not available in external forks/branches)

@ojii
Copy link
Contributor

ojii commented Dec 16, 2020

I've no clue why the "remote" (browserstack) tests suddenly fail...

external PRs cannot run remote tests as they don't get access to API Keys. Curious why it's not skipping them though

@dimaqq dimaqq merged commit 942d0a0 into HENNGE:main Jan 12, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants