Weaver jet flavour inference #188
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
forthommel
commented
Jul 25, 2022
vvolkl
requested changes
Aug 1, 2022
forthommel
commented
Aug 1, 2022
forthommel
commented
Aug 1, 2022
analyzers/dataframe/CMakeLists.txt
Outdated
| set(EXTRA_LIBRARIES) | ||
|
|
||
| if(${WITH_ONNX}) | ||
| find_package(ONNXRuntime) |
This comment was marked as outdated.
This comment was marked as outdated.
Sorry, something went wrong.
vvolkl
reviewed
Aug 1, 2022
vvolkl
reviewed
Aug 1, 2022
vvolkl
reviewed
Aug 1, 2022
…unt for systems where ONNXRuntime is not installed
vvolkl
approved these changes
Aug 1, 2022
|
Thanks to you for this very fast and efficient review and interaction! |
This was referenced Aug 4, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR introduces the capacity to infer jet flavours from an
ONNXmodel prepared with @hqucms' Weaver toolbox.Given a list of jet constituents kinematic and physical properties, the jet flavour weight is computed using the
ONNXRuntimelibrary (present on v102 of LCG's SW stack, but not yet on HSF's spackages) for which the API is simplified and matched to Weaver's output. Therefore, three new utilities namespaces/objects are introduced: the ONNXRuntime interface, the Weaver variables translation interface, and the JetFlavourUtils RDF tools.Additionally, a unit test is introduced, along with an example which can be run at integration tests.