Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Addons refactoring #194

Merged
merged 6 commits into from Aug 8, 2022
Merged

Addons refactoring #194

merged 6 commits into from Aug 8, 2022

Conversation

forthommel
Copy link
Contributor

This PR splits the newly-introduced ONNXRuntime/Weaver interfacing from the RDF component, and thus allows to factorise add-ons from the analysis helpers.

More libraries interfacing may be added as a addons/xxx extra folder with appropriate CMake directive (a CMake function can furthermore be introduced to simplify the declaration of these plugins).

forthommel and others added 2 commits August 8, 2022 12:09
Co-authored-by: Valentin Volkl <valentin.volkl@cern.ch>
Copy link
Member

@vvolkl vvolkl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, this is indeed a better organization.

@vvolkl vvolkl merged commit 6eb7b0e into HEP-FCC:master Aug 8, 2022
@forthommel forthommel deleted the addons-refactoring branch August 8, 2022 12:55
forthommel added a commit to forthommel/FCCAnalyses that referenced this pull request Aug 9, 2022
Added the new `addons` directory introduced in HEP-FCC#194 to the sources search path.
vvolkl pushed a commit that referenced this pull request Aug 9, 2022
Added the new `addons` directory introduced in #194 to the sources search path.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants