Added jets_TwoHemispheres to Algorithms. #241
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
It splits an event in two hemispheres based on the thrust axis, and gathers together all reco'ed particles
that belong to each hemisphere into a "jet", in the format of JetClustering::FCCAnalysesJet, such
that algorithms (e.g. tagging) developed on JetClustering::FCCAnalysesJet's can be used.
On Z -> had events, the resulting jets are very similar to jets from Durham exclusive, N = 2, although
a few particles occasionnaly get clustered differently in the two approaches.
Example usage:
.Define("FCCAnalysesJets_hemispheres", "Algorithms::jets_TwoHemispheres( 1, 0) ( ReconstructedParticles )")
.Define("jets_hemispheres", "JetClusteringUtils::get_pseudoJets( FCCAnalysesJets_hemispheres )")
.Define("jets_hemispheres_px", " JetClusteringUtils::get_px( jets_hemispheres )")
kjvbrt
reviewed
Feb 20, 2023
| @@ -6,6 +6,9 @@ | |||
|
|
|||
| #include "edm4hep/ReconstructedParticleData.h" | |||
|
|
|||
| #include "FCCAnalyses/JetClusteringUtils.h" | |||
| #include "FCCAnalyses/ReconstructedParticle.h" | |||
|
|
|||
There was a problem hiding this comment.
Can you move those includes to the .cc file?
There was a problem hiding this comment.
OK, I've updated the implementation. I still need JetClustering.h, though.
kjvbrt
reviewed
Feb 20, 2023
|
|
||
| ROOT::VecOps::RVec<float> mt = minimize_thrust("Minuit2","Migrad")(RP_px, RP_py, RP_pz) ; | ||
| ROOT::VecOps::RVec<float> costheta = getAxisCosTheta( mt, RP_px, RP_py, RP_pz) ; | ||
|
|
There was a problem hiding this comment.
These should be inputs to the function. Maybe then the additional includes won't be needed.
There was a problem hiding this comment.
I had chosen the implementation that maximally hides the complexity to the user. But OK, I have updated the implementation along the lines you suggested.
Here is the new usage:
.Define("RP_px", "ReconstructedParticle::get_px(ReconstructedParticles) ")
.Define("RP_py", "ReconstructedParticle::get_py(ReconstructedParticles) ")
.Define("RP_pz", "ReconstructedParticle::get_pz(ReconstructedParticles) ")
.Define("RP_e", "ReconstructedParticle::get_e(ReconstructedParticles) ")
.Define("thrust", 'Algorithms::minimize_thrust("Minuit2","Migrad")(RP_px, RP_py, RP_pz)')
.Define("RP_costheta", "Algorithms::getAxisCosTheta( thrust, RP_px, RP_py, RP_pz)" )
.Define("FCCAnalysesJets_hemispheres", "Algorithms::jets_TwoHemispheres( 1, 0) ( RP_px, RP_py, RP_pz, RP_e, RP_costheta )")
|
looks good to me :) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
It splits an event in two hemispheres based on the thrust axis, and gathers together all reco'ed particles that belong to each hemisphere into a "jet", in the format of JetClustering::FCCAnalysesJet, such that algorithms (e.g. tagging) developed on JetClustering::FCCAnalysesJet's can be used.
On Z -> had events, the resulting jets are very similar to jets from Durham exclusive, N = 2, although a few particles occasionnaly get clustered differently in the two approaches.
Example usage: