Updated vertexing: link to the code that is in Delphes #247
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…elphes. So far: the vertexing code from Franco (an old version of it) had been copied/pasted into FCCAnalyses, in VertexFitterSimple (that was dumb of course, but easy, e.g. no need to figure out how to compile the FCCAnalyses code using delphes as a library). Now Delphes is linked properly, and the Vertexing code of FCCAnalyses has been purged from all the code that had been copied. Moreover: the vertexing code of Franco is now an updated version (see his presentation at the Physics Performance meeting of July 2022). The FCCAnalyses method that retrieves the primary tracks has been updated - the old code would still work, but is very unefficient, with plenty of the (new) VertexFit objects created in a recursive method. Performance recovered with this update. Updated the vertexing examples to comply with the updated primary tracks retrieval.
…ue to meters-mm units; Added converters between the edm4hep and delphes conventiond for track parameters and convariance matrices; Small bugfix in get_PrimaryTracks.
…he simplifications made in the previous commit; - added an example in examples/FCCee/tutorials/vertexing that shows how to use the VertexMore class of Franco. The example, analysis_Bs2DsK_MCseeded.py, reconstructs the Bs vertex in Bs to Ds(KKpi)K using the tracks that are matched to the MC-truth particles from this decay. A simple script, plots_Bs2DsK.x, makes basic validation plots.
BrieucF
changed the title
kjvbrt
reviewed
Mar 22, 2023
kjvbrt
reviewed
Mar 22, 2023
…e in this PR: - update of XPtoPar to VertexingUtils::XPtoPar (wrapper to the code that is in delphes) - some simplifications, making use of the conversion methods now included in VertexingUtils (Delphes2Edm4hep_TrackParam and Delphes2Edm4hep_TrackCovMatrix)
…github machines can see the files
added utilities for smearing dndx and tof
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Update of vertexing code: move to the code from Franco B that is in Delphes.
Simplified the gymnastic in delphes-edm4hep translations due to meters-mm units; Added converters between the edm4hep and delphes conventiond for track parameters and convariance matrices; Small bugfix in get_PrimaryTracks.
Added example for Bs to Ds K