Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add general knob turning #57

Closed
kreczko opened this issue Mar 2, 2016 · 3 comments · Fixed by #95
Closed

Add general knob turning #57

kreczko opened this issue Mar 2, 2016 · 3 comments · Fixed by #95
Assignees
Milestone

Comments

@kreczko
Copy link
Member

kreczko commented Mar 2, 2016

HTCondor has many parameters and they cannot be mapped 1:1 in the puppet module.
My suggestions would be to replace custom_attribute with something like a knobs array or hash that will create entries in /etc/condor/conf.d/00_local (see #56).

@kreczko kreczko self-assigned this Mar 2, 2016
@kreczko kreczko added this to the Version 2.0 milestone Mar 2, 2016
@ccnifo
Copy link
Collaborator

ccnifo commented Dec 27, 2017

If I understood what you describe, it could be an array or a hash, sent to a create_resource, which would create a file_line for each entry?

@ccnifo
Copy link
Collaborator

ccnifo commented Jul 5, 2018

Can it be this kind of logic, with a simple hash and no checks? https://github.com/HEP-Puppet/htcondor/blob/0f64542c5afc0eead8c490835b2775dbbd7fab62/templates/14_logging.config.erb

@kreczko
Copy link
Member Author

kreczko commented Jul 16, 2018

@ccnifo Apologies for the delayed reply - it's conference season.
Yes, a simple hash could be a good first implementation for this.
Should go into a separate config file so users are aware of the special case (anything goes).

ccnifo pushed a commit to ccin2p3/htcondor that referenced this issue Jul 17, 2018
ccnifo pushed a commit to ccin2p3/htcondor that referenced this issue Jul 17, 2018
ccnifo pushed a commit to ccin2p3/htcondor that referenced this issue Jul 17, 2018
ccnifo pushed a commit to ccin2p3/htcondor that referenced this issue Jul 17, 2018
ccnifo pushed a commit to ccin2p3/htcondor that referenced this issue Jul 17, 2018
ccnifo pushed a commit to ccin2p3/htcondor that referenced this issue Jul 17, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants