Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Regression] Unable to specify actual expression for SINGULARITY_IMAGE_EXPR since 2.0.7 #91

Closed
olifre opened this issue May 31, 2018 · 0 comments · Fixed by #92
Closed

[Regression] Unable to specify actual expression for SINGULARITY_IMAGE_EXPR since 2.0.7 #91

olifre opened this issue May 31, 2018 · 0 comments · Fixed by #92

Comments

@olifre
Copy link
Collaborator

olifre commented May 31, 2018 •
edited
Loading

Broken by #90, Version 2.0.7 forcefully added double quotes around the image expression, degrading it to a string, thus enforcing users to specify a single image location only.

This prevents e.g. the following usecase:

In Puppet:

singularity_image_expr  =>   '$(CHOSEN_IMAGE)'

Which created the following config before 2.0.7:

SINGULARITY_IMAGE_EXPR = $(CHOSEN_IMAGE)

Elsewhere in our condor-config, we define:

SL6_DEFAULT_IMAGE = /somewhere/SL6
UBUNTU1604_DEFAULT_IMAGE = /somewhere/Ubuntu1604
CHOSEN_IMAGE = "$(SL6_DEFAULT_IMAGE)"
CHOSEN_IMAGE = ifThenElse(TARGET.ContainerOS is "Ubuntu1604", "$(UBUNTU1604_DEFAULT_IMAGE)", $(CHOSEN_IMAGE))

This is broken in 2.0.7, and one can only ever use a single image, which is a severe loss of functionality.
@olifre olifre mentioned this issue May 31, 2018
Merged
@olifre olifre changed the title Unable to specify actual expression for SINGULARITY_IMAGE_EXPR since 2.0.7 [Regression] Unable to specify actual expression for SINGULARITY_IMAGE_EXPR since 2.0.7 May 31, 2018
olifre added a commit to olifre/puppet-htcondor that referenced this issue May 31, 2018
@olifre
Revert "SINGULARITY_IMAGE_EXPR needs to be within double-quotes for H…
2f14a6e 
…TCondor to parse it correctly"

This reverts commit e7e4914.

It's actually an expression, and adding double quotes degrades it to a simple string,
forcing users to specify a single image only.

Fixes HEP-Puppet#91.
@olifre olifre mentioned this issue May 31, 2018
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Fixup SINGULARITY_IMAGE_EXPR olifre/puppet-htcondor
1 participant
@olifre