Condor id fix, better tests and puppet-lint fixes

[kreczko]

Condor ID is now set only if uid/gid > 0:

<% if @condor_user == 'root' and @condor_group == 'root' -%>
CONDOR_IDS = 0.0
<% elsif @condor_uid.to_i > 0 and @condor_gid.to_i > 0 -%>
CONDOR_IDS = <%= @condor_uid %>.<%= @condor_gid %>
<% end -%>

@fschaer @kashif74 is that OK?

This pull request also includes better tests:
bundle exec rake validate && bundle exec rake lint && bundle exec rake spec SPEC_OPTS='--format documentation'
is executed on travis. I would like to make it default for all HEP-Puppet modules. What do you think?
It will need more documentation (e.g show the requirements [1]). Everything else is added to make the tests pass (syntax + layout)

[1]
gem install rspec rspec-puppet bundler puppet puppetlabs_spec_helper puppet-lint

[fschaer]

Hi,

I’m away for now, but this seems ok to me … ?

[kashif74]

It looks fine to me.

[kreczko]

OK, I will merge it, but first I am going to create a release/tag just in case.
I am updating our cluster this and next week and want to get all improvements back into the repo.