htcondor::sharedport: Add configuration for condor_shared_port daemon. #62
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kreczko
requested changes
Jul 14, 2017
| content => template($template_sharedport), | ||
| require => Package['condor'], | ||
| owner => $condor_user, | ||
| group => $condor_group, |
There was a problem hiding this comment.
Puppet lint is complaining about lines 17 and 18:
manifests/config/sharedport.pp - WARNING: top-scope variable being used without an explicit namespace on line 17
manifests/config/sharedport.pp - WARNING: top-scope variable being used without an explicit namespace on line 18
Could you please add
$condor_user = $htcondor::condor_user
$condor_group = $htcondor::condor_group
?
There was a problem hiding this comment.
Done, thanks for reviewing!
olifre
force-pushed
the
shared-port-configuration
branch
from
edc8af2
to
bcfdc10
Compare
kreczko
approved these changes
Jul 14, 2017
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Extremely useful in firewalled environments, off by default.