Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Check that data_file has file extension .yaml or .json #57

Open
GraemeWatt opened this issue Apr 9, 2024 · 0 comments
Open

Check that data_file has file extension .yaml or .json #57

GraemeWatt opened this issue Apr 9, 2024 · 0 comments
Labels

Comments

@GraemeWatt
Copy link
Member

Other data file extensions than .yaml and .json are currently accepted by the validator (e.g. .yalm) but these data files are then not included in the tarfile prepared by the hepdata-converter-ws-client package (see this line). Consequently, file conversion fails with a FileNotFoundError error message from this line of the hepdata-converter package. An example is https://www.hepdata.net/record/85727?version=2 (data files with extension .yalm) fixed in https://www.hepdata.net/record/85727?version=3 (data files with extension .yaml).

A "pattern": "^.+\\.(yaml|json)$" should be specified for data_file in the JSON schema:

@GraemeWatt GraemeWatt added the bug label Apr 9, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
Status: To do
Development

No branches or pull requests

1 participant