Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Schema v1.1.0 - bug fixes and cli #32

Merged
merged 39 commits into from
Sep 23, 2021
Merged

Schema v1.1.0 - bug fixes and cli #32

merged 39 commits into from
Sep 23, 2021

Commits on Jul 2, 2021

  1. Ensure either high and low are both specified

    Added schema v1.0.2 to achieve this - may need to make further changes.
    Modified error handling in data_file_validator to give better errors for this case.
    
    Fixes #30
    alisonrclarke committed Jul 2, 2021
    Configuration menu
    Copy the full SHA
    c982050 View commit details
    Browse the repository at this point in the history
  2. Configuration menu
    Copy the full SHA
    293a656 View commit details
    Browse the repository at this point in the history
  3. Configuration menu
    Copy the full SHA
    33e726b View commit details
    Browse the repository at this point in the history

Commits on Jul 7, 2021

  1. Configuration menu
    Copy the full SHA
    615f28b View commit details
    Browse the repository at this point in the history
  2. Configuration menu
    Copy the full SHA
    02bc45e View commit details
    Browse the repository at this point in the history

Commits on Jul 8, 2021

  1. Added checks for duplicate table names and data_files

    As we're now checking for more complex version numbers I've added the
    'packaging' package to parse and compare for us, and modified the
    Validator to use `self.schema_version_string` for the string version, and
    `self.schema_version` for the parsed packaging.version.Version object.
    
    Fixes #24
    alisonrclarke committed Jul 8, 2021
    Configuration menu
    Copy the full SHA
    77eccdf View commit details
    Browse the repository at this point in the history
  2. Configuration menu
    Copy the full SHA
    32b8abe View commit details
    Browse the repository at this point in the history

Commits on Jul 12, 2021

  1. Configuration menu
    Copy the full SHA
    e063531 View commit details
    Browse the repository at this point in the history

Commits on Jul 14, 2021

  1. Configuration menu
    Copy the full SHA
    676aaf6 View commit details
    Browse the repository at this point in the history
  2. Configuration menu
    Copy the full SHA
    344bed1 View commit details
    Browse the repository at this point in the history
  3. Configuration menu
    Copy the full SHA
    ec7e19c View commit details
    Browse the repository at this point in the history
  4. Configuration menu
    Copy the full SHA
    dc165e6 View commit details
    Browse the repository at this point in the history
  5. Configuration menu
    Copy the full SHA
    a206ac9 View commit details
    Browse the repository at this point in the history
  6. Use v1.1.0 instead of v1.0.2

    Additional resources is a minor change rather than bug fix.
    alisonrclarke committed Jul 14, 2021
    Configuration menu
    Copy the full SHA
    0563761 View commit details
    Browse the repository at this point in the history

Commits on Jul 15, 2021

  1. Configuration menu
    Copy the full SHA
    ff8758e View commit details
    Browse the repository at this point in the history

Commits on Jul 27, 2021

  1. Configuration menu
    Copy the full SHA
    395d2ed View commit details
    Browse the repository at this point in the history
  2. Updated docs

    alisonrclarke committed Jul 27, 2021
    Configuration menu
    Copy the full SHA
    bec110e View commit details
    Browse the repository at this point in the history

Commits on Aug 5, 2021

  1. Configuration menu
    Copy the full SHA
    e9e6e4e View commit details
    Browse the repository at this point in the history
  2. Configuration menu
    Copy the full SHA
    0b489f5 View commit details
    Browse the repository at this point in the history

Commits on Aug 11, 2021

  1. Configuration menu
    Copy the full SHA
    40ed860 View commit details
    Browse the repository at this point in the history
  2. Allow access to submission docs; fix schemas; improve documentation

     * Hides validators that are for internal use.
     * Fixed argument passing to validators so that old schemas work
     * Added class level docs
    alisonrclarke committed Aug 11, 2021
    Configuration menu
    Copy the full SHA
    df0c35a View commit details
    Browse the repository at this point in the history
  3. Configuration menu
    Copy the full SHA
    59bd10f View commit details
    Browse the repository at this point in the history
  4. Allow old-style resources for v0 schema

    This aligns things with the hepdata code.
    alisonrclarke committed Aug 11, 2021
    Configuration menu
    Copy the full SHA
    82866ce View commit details
    Browse the repository at this point in the history
  5. Configuration menu
    Copy the full SHA
    bca5a79 View commit details
    Browse the repository at this point in the history

Commits on Aug 12, 2021

  1. Update docs

    alisonrclarke committed Aug 12, 2021
    Configuration menu
    Copy the full SHA
    e1f7b24 View commit details
    Browse the repository at this point in the history

Commits on Aug 17, 2021

  1. Add option to disallow automatic remote schema loading

    For use by main hepdata app, so it can preload the allowed remote schemas.
    
    Also made custom_data_schemas in DataFileValidator an instance variable
    so it's clear which schemas have been loaded for which validator.
    alisonrclarke committed Aug 17, 2021
    Configuration menu
    Copy the full SHA
    0688a68 View commit details
    Browse the repository at this point in the history

Commits on Sep 2, 2021

  1. Configuration menu
    Copy the full SHA
    bf854b0 View commit details
    Browse the repository at this point in the history
  2. Return multiple errors in data files and update tests

    Tests add checks for previous schema change as well as checking for multiple errors
    alisonrclarke committed Sep 2, 2021
    Configuration menu
    Copy the full SHA
    11c974a View commit details
    Browse the repository at this point in the history
  3. Display all error messages when validating, not just first/best.

    Follows pattern previously used for our own data schema but now works
    for submissions and remote schemas.
    alisonrclarke committed Sep 2, 2021
    Configuration menu
    Copy the full SHA
    9390bf7 View commit details
    Browse the repository at this point in the history

Commits on Sep 3, 2021

  1. Move check for ranges to python to give more informative error messages

    Also do all further checks even if there's been a previous error, to ensure
    all errors are returned.
    alisonrclarke committed Sep 3, 2021
    Configuration menu
    Copy the full SHA
    dd5d463 View commit details
    Browse the repository at this point in the history

Commits on Sep 6, 2021

  1. Fix dodgy logic and regex

    Also added some valid expressions with - to tests to ensure they are
    allowed
    alisonrclarke committed Sep 6, 2021
    Configuration menu
    Copy the full SHA
    18d0bc3 View commit details
    Browse the repository at this point in the history

Commits on Sep 7, 2021

  1. Changes following review

     * Rename zipfile to archive in parameters/docs
     * Allow .yaml.gz files as single file archive
    alisonrclarke committed Sep 7, 2021
    Configuration menu
    Copy the full SHA
    cf255f0 View commit details
    Browse the repository at this point in the history

Commits on Sep 8, 2021

  1. Configuration menu
    Copy the full SHA
    079e6d8 View commit details
    Browse the repository at this point in the history

Commits on Sep 14, 2021

  1. Configuration menu
    Copy the full SHA
    cd4d5e6 View commit details
    Browse the repository at this point in the history

Commits on Sep 15, 2021

  1. Add check that a submission has at least 1 doc that validates against…

    … the submission schema
    
    Fixes #34
    alisonrclarke committed Sep 15, 2021
    Configuration menu
    Copy the full SHA
    544601c View commit details
    Browse the repository at this point in the history

Commits on Sep 16, 2021

  1. Only restrict to docs with at least 1 submission in v1 schema

    Added test for this case.
    alisonrclarke committed Sep 16, 2021
    Configuration menu
    Copy the full SHA
    364c1a8 View commit details
    Browse the repository at this point in the history
  2. Configuration menu
    Copy the full SHA
    73d22d8 View commit details
    Browse the repository at this point in the history
  3. Configuration menu
    Copy the full SHA
    8ecaed0 View commit details
    Browse the repository at this point in the history

Commits on Sep 23, 2021

  1. Configuration menu
    Copy the full SHA
    0d67d29 View commit details
    Browse the repository at this point in the history