Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

records: allow submitters to preview bidirectional links #796

Closed
GraemeWatt opened this issue Jun 5, 2024 · 1 comment
Closed

records: allow submitters to preview bidirectional links #796

GraemeWatt opened this issue Jun 5, 2024 · 1 comment
Assignees
Labels
complexity: medium priority: high type: bug Indicates an unexpected problem or unintended behaviour

Comments

@GraemeWatt
Copy link
Member

Information specified by the related_to_table_dois and related_to_hepdata_records fields is not currently rendered when a record is in preparation and has not yet been finalised, probably because of the changes made in PR #732 to improve the linking of records/tables for records with multiple versions. This makes it difficult for submitters to know if they have specified these fields correctly, leading to situations like https://www.hepdata.net/record/ins2729396?version=1 where duplicate links appear because the bidirectional links have been specified both ways in the encoding. The following changes should be made:

  • The related_to_table_dois links in the forward direction should always be shown irrespective of whether the two related records are in preparation or finalised.
  • The related_to_table_dois links in the backward direction should be shown if the records containing the referring tables have been finalised or if the referring tables are in the same record (which might not be finalised).
  • The related_to_hepdata_records links in the forward direction should always be shown irrespective of whether the two related records are in preparation or finalised.
  • The related_to_hepdata_records links in the backward direction should only be shown if the most recent versions of the referring records have been finalised.

Could you please look into these issues, @ItIsJordan?

@GraemeWatt GraemeWatt added type: bug Indicates an unexpected problem or unintended behaviour priority: high complexity: medium labels Jun 5, 2024
GraemeWatt added a commit to HEPData/hepdata-submission that referenced this issue Jun 5, 2024
* Give an example and mention issue HEPData/hepdata#796.
ItIsJordan added a commit that referenced this issue Jun 27, 2024
Implements a number of changes listed in #796 to forward relations ( which now appear even if relating object is not finished). As well as changes in the backwards direction, to allow tables within the same HEPSubmission to reference another in the same one.
ItIsJordan added a commit that referenced this issue Jun 27, 2024
Adds a new test to cover #796 and to potentially expand on and improve bidirectional/version relation testing.
@GraemeWatt
Copy link
Member Author

Closed by PR #805.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
complexity: medium priority: high type: bug Indicates an unexpected problem or unintended behaviour
Projects
Status: Done
Development

No branches or pull requests

2 participants