Large file bugfixes fix #769
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fixes an issue as a part of the large file loading bugs in #756 where the filesize threshold loading button would execute multiple queries. This occurred by multiple events being passed to the button. Now clears the buton events before.
Updates tests in response to previous commit.
Updates the table renderer JS to properly use new route to select only data table.
Refactors the route to get data tables at /data/ to separate the data table (yaml file) and the headers query code. Implements a second route to select only the table data.
Fixes a bug where the table_options_region element ("Showing X of X values" and "Show All") on the records page would sometimes have the data of another table if loaded later.
Now triggers rendering of LaTeX in record table descriptions as this was bugged and only occurred when the full table is loaded. Mentioned in issue #756
GraemeWatt
force-pushed
the
large-file-bugfixes-fix
branch
from
8e2f38f
to
650154a
Compare
GraemeWatt
approved these changes
Mar 11, 2024
There was a problem hiding this comment.
Great work! I've checked that all the bugs listed in #756 are now fixed. I'll merge now.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds a new endpoint for specifically selecting individual data tables to avoid duplicate selecting of data, and allow specific table data selecting, where previously all table data was returned.
Fixes a number of bugs introduced in pull request #733:
Closes #756.