Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update Release action #165

Closed
clelange opened this issue May 6, 2021 · 6 comments · Fixed by #256
Closed

Update Release action #165

clelange opened this issue May 6, 2021 · 6 comments · Fixed by #256

Comments

@clelange
Copy link
Collaborator

clelange commented May 6, 2021

minor

@AndreasAlbert
Copy link
Collaborator

Could consider automatizing the pypi publication via github actions, see e.g. here

in that example, pypi upload is triggered automatically when a new tag is pushed. Just have to figure out how to make sure that it only triggers when the new tag the master (to avoid people randomly tagging stuff)

@clelange
Copy link
Collaborator Author

clelange commented May 6, 2021

OK, I'll try to look into this next week. I think I found something in this direction somewhere else that protects us from all the pitfalls.

@GraemeWatt
Copy link
Member

For some other HEPData packages (hepdata-cli, hepdata-converter, hepdata-validator, hepdata-converter-ws, hepdata-converter-ws-client), we trigger a PyPI upload via GitHub Actions by making a GitHub Release. This method might work for hepdata_lib too. See, for example, deploy job for hepdata-cli.

@clelange clelange changed the title Release Update Release action Oct 20, 2023
@clelange
Copy link
Collaborator Author

To fix this eventually, follow https://til.simonwillison.net/pypi/pypi-releases-from-github

@GraemeWatt
Copy link
Member

I'm already using PyPI's trusted publishing for the other HEPData repositories, so I can take a look if you get stuck. By the way, could you please add user "hepdata" as a Maintainer or Owner of hepdata-lib on PyPI (https://pypi.org/manage/project/hepdata-lib/collaboration/)?

@clelange
Copy link
Collaborator Author

By the way, could you please add user "hepdata" as a Maintainer or Owner of hepdata-lib on PyPI (https://pypi.org/manage/project/hepdata-lib/collaboration/)?

Invite sent.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants