Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Dockerfile: Make sure to use Fedora-based root container #164

Merged
merged 1 commit into from
May 6, 2021

Conversation

AndreasAlbert
Copy link
Collaborator

The setup in the Dockerfile is based on the assumption that the base container is Fedora based. However, apparently root changed their tag structure, so 'latest' does not point to Fedora anymore. They still have specific Fedora tags and switching to that fixes the Docker build. @clelange please check if this makes sense to you

@AndreasAlbert
Copy link
Collaborator Author

AndreasAlbert commented May 6, 2021

I tested this by running:

docker build --build-arg BUILD_DATE=`date -u +"%Y-%m-%dT%H:%M:%SZ"` --build-arg VCS_REF=`git rev-parse --short HEAD` --build-arg VCS_URL=`git config --get remote.origin.url`  .

which produced a successful build.

Copy link
Collaborator

@clelange clelange left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Awesome, thanks a lot! Shall we create new release once this is merged?

@clelange clelange merged commit 318b049 into master May 6, 2021
@clelange clelange deleted the 2021-05-06_fix_docker branch May 6, 2021 13:37
@AndreasAlbert AndreasAlbert mentioned this pull request Jun 16, 2021
3 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants