Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Reenable pylint #45

Merged
merged 10 commits into from
Jun 25, 2018
Merged

Reenable pylint #45

merged 10 commits into from
Jun 25, 2018

Conversation

clelange
Copy link
Collaborator

  • fix all pylint errors and warnings that were introduced in the meantime

With a clean environment, I managed to get the tests to run on lxplus as well (using CMSSW_8_0_20 and a virtualenv).

@AndreasAlbert Can you please also try on lxplus and your setup?

Closes #43

@clelange
Copy link
Collaborator Author

Alright, so this seems to be working now. On lxplus, tests run successfully in CMSSW_9_4_6_patch1 (ROOT 6.10), but fail in CMSSW_8_0_20 (ROOT 6.06) as described in #46.
I suggest we recommend as setup CMSSW_9_4_6_patch1 and/or ROOT >= 6.10.
For things to work properly, one needs to use python -m pip instead of just pip.
For usage, no virtualenv seems necessary:

python -m pip install --user hepdata_lib

For development I'd suggest we recommend:

virtualenv HEPData -p `which python`
source HEPData/bin/activate
git clone git@github.com:clelange/hepdata_lib.git
python -m pip install -e .

If you agree, I can write some documentation.

Last question: should we run pylint on the tests as well? Currently, this would fail...

Let's merge this.

@clelange clelange mentioned this pull request Jun 24, 2018
@AndreasAlbert AndreasAlbert merged commit 36df5e6 into master Jun 25, 2018
@AndreasAlbert AndreasAlbert deleted the reenable_pylint branch June 25, 2018 07:44
SirVheod pushed a commit to SirVheod/hepdata_lib that referenced this pull request Mar 23, 2020
* run pylint again

* fix pylint errors

* fix RuntimeWarning from ROOT due to reuse of same histogram name and fix broken spacebar

* fix further ROOT features

* improve naming of test hists

* fix typo, but does not solve the problem

* add pylint and enum34 dependencies again

* run pylint only in travis CI tests

* prepend python3 -m to pylint

* install package for dependencies first
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

pylint currently not working
2 participants