-
Notifications
You must be signed in to change notification settings - Fork 37
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Reenable pylint #45
Reenable pylint #45
Conversation
…fix broken spacebar
17f6b80
to
0b8254f
Compare
Alright, so this seems to be working now. On lxplus, tests run successfully in
For development I'd suggest we recommend:
If you agree, I can write some documentation. Last question: should we run Let's merge this. |
* run pylint again * fix pylint errors * fix RuntimeWarning from ROOT due to reuse of same histogram name and fix broken spacebar * fix further ROOT features * improve naming of test hists * fix typo, but does not solve the problem * add pylint and enum34 dependencies again * run pylint only in travis CI tests * prepend python3 -m to pylint * install package for dependencies first
With a clean environment, I managed to get the tests to run on lxplus as well (using
CMSSW_8_0_20
and a virtualenv).@AndreasAlbert Can you please also try on lxplus and your setup?
Closes #43