Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

change dir name to docs and edit README for that #588

Merged
merged 5 commits into from
Apr 27, 2022
Merged

Conversation

david-deboer
Copy link
Contributor

For naming convenience, changed Docs sub-directory name to docs.

@codecov
Copy link

codecov bot commented Apr 25, 2022

Codecov Report

Merging #588 (f5e3f42) into main (b618805) will not change coverage.
The diff coverage is 100.00%.

@@           Coverage Diff           @@
##             main     #588   +/-   ##
=======================================
  Coverage   97.76%   97.76%           
=======================================
  Files          35       35           
  Lines        5110     5110           
=======================================
  Hits         4996     4996           
  Misses        114      114           
Impacted Files Coverage Δ
hera_mc/cm_utils.py 100.00% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update b618805...f5e3f42. Read the comment docs.

@bhazelton
Copy link
Member

It looks like this is somehow dropping coverage for line 1426 of correlator.py. I don't really understand why that would be. @david-deboer I think this is code you wrote, any insight?

@david-deboer
Copy link
Contributor Author

The tests must be using the production version of redis. Recall we are running on a branch for hera_corr_cm with the new implementation, which must change the id format such that it doesn't produce the same list.

Copy link
Member

@bhazelton bhazelton left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!!

@bhazelton bhazelton merged commit 92c84cb into main Apr 27, 2022
@bhazelton bhazelton deleted the change-docs-dirname branch April 27, 2022 00:10
@bhazelton bhazelton added continuous_integration Related to CI and testing but not strictly impacting codebase packaging labels May 2, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
continuous_integration Related to CI and testing but not strictly impacting codebase packaging
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants