minor fixes and cleanup #596
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## main #596 +/- ##
==========================================
+ Coverage 97.77% 97.93% +0.16%
==========================================
Files 35 35
Lines 5114 5090 -24
==========================================
- Hits 5000 4985 -15
+ Misses 114 105 -9
Continue to review full report at Codecov.
|
hera_mc/__init__.py
Outdated
| if isinstance(self_c, int): | ||
| if self_c != other_c: | ||
| print("column {col} is int, values are not equal".format(col=c)) | ||
| print(f"column {c} is int, values are not equal") |
There was a problem hiding this comment.
Should change the looping variable from c to, say, col.
Discovered while debugging Exception messages passed from hera_corr_cm
No associated Alembic change because we don't want to delete the table on site
plaplant
approved these changes
May 23, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
While working on adding support for handling Exception messages passed from hera_corr_cm, I found a few things that needed to be fixed/cleaned up. There has since been work to eliminate those from the output of hera_corr_cm, so this doesn't include that support.
I also added some other cleanup items from our issues:
Motivation and Context
fixes #586
fixes #543
Types of changes
Checklist:
Other:
changes when this is merged. None required