Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Get obsid from uvh5 files #56

Merged
merged 2 commits into from
Nov 16, 2018
Merged

Get obsid from uvh5 files #56

merged 2 commits into from
Nov 16, 2018

Conversation

plaplant
Copy link
Member

This PR gets an obsid from a uvh5 file. Instead of being explicitly stored on the object, we use the GPS second corresponding to the first time in the observation. This is self-consistent with how hera_mc calculates the obsid.

@plaplant plaplant requested a review from pkgw November 16, 2018 03:36
Copy link
Contributor

@pkgw pkgw left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

Small stylistic comment, for functions with control paths like get_obsid_like_path, I like to structure them more like:

if caseA:
   return resultA

if caseB:
   return resultB

return None

… rather than nesting if-else's. But I doubt we're ever going to have more than two cases in this function, so, meh.

@pkgw pkgw merged commit 514ea9e into master Nov 16, 2018
@pkgw pkgw deleted the uvh5_support branch November 16, 2018 14:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants