Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add some connectivity diagnostics infrastructure #68

Merged
merged 8 commits into from
Jan 29, 2020

Conversation

pkgw
Copy link
Contributor

@pkgw pkgw commented Jan 27, 2020

This PR adds several pieces of diagnostics functionality. It might be helpful to read the commits in order, but the new user-facing features are:

  • A new command librarian check-connections, intended to be run from a Librarian store host. This will look at all of the Librarian connections defined in ~/.hl_client.cfg and attempt to connect to each one. For each connection, it will ask for a list of all of its (available) stores and see if it can connect to them.
  • The new Web UI endpoint /connectivity-check, accessible through the Admin menu, will run the above connectivity check on all stores attached to the Librarian server. This basically validates that all of the stores on this Librarian know how to talk to all of the stores on the other Librarians that this Librarian is aware of.

No user-facing documentation or tests; this is about as much time as I can spend on this stuff this week.

Edit: BTW, I tested this stuff by fooling around on folio2. Not exactly a torture test but I think it will all work?

Copy link
Member

@plaplant plaplant left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is an awesome feature, thanks so much @pkgw! Testing on folio sounds good enough for me. If other issues pop up, we can always make a new PR at that point.

@plaplant plaplant merged commit 2d4164b into HERA-Team:master Jan 29, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants