Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

test: use frame kwarg for tests SkyModels #67

Merged
merged 2 commits into from
Aug 10, 2023
Merged

Conversation

steven-murray
Copy link
Contributor

@steven-murray steven-murray commented Aug 1, 2023

Description

Simply updates the SkyModel() call in tests to use the frame keyword.

Issues

Checklist

I have

  • Added a test covering your new feature adequately?
  • Added a docstring (or note to a docstring) describing your feature?
  • (Optional): Added a tutorial / section to a tutorial showing usage of your new feature?
  • Important: this feature does not break API compatibility.

@steven-murray steven-murray self-assigned this Aug 1, 2023
@codecov
Copy link

codecov bot commented Aug 1, 2023

Codecov Report

Patch and project coverage have no change.

Comparison is base (d2e21d5) 100.00% compared to head (78dccaa) 100.00%.
Report is 1 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff            @@
##              main       #67   +/-   ##
=========================================
  Coverage   100.00%   100.00%           
=========================================
  Files            8         8           
  Lines          567       567           
  Branches        88        88           
=========================================
  Hits           567       567           
Flag Coverage Δ
unittests 99.29% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Collaborator

@r-pascua r-pascua left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me! Thanks!

@steven-murray steven-murray merged commit 234f7f2 into main Aug 10, 2023
13 checks passed
@steven-murray steven-murray deleted the fix-for-pyradiosky branch August 10, 2023 16:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants