Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor: rename vis_cpu to matvis #72

Merged
merged 9 commits into from
Nov 30, 2023
Merged

refactor: rename vis_cpu to matvis #72

merged 9 commits into from
Nov 30, 2023

Conversation

piyanatk
Copy link
Collaborator

This PR rename vis_cpu to matvis following the consensus from the paper. It will also require refactoring in hera_sim

Copy link

Check out this pull request on  ReviewNB

See visual diffs & provide feedback on Jupyter Notebooks.


Powered by ReviewNB

Copy link

codecov bot commented Nov 26, 2023

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (2bdfab8) 100.00% compared to head (1ecce4f) 100.00%.
Report is 1 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff            @@
##              main       #72   +/-   ##
=========================================
  Coverage   100.00%   100.00%           
=========================================
  Files            8         8           
  Lines          567       566    -1     
  Branches        88        88           
=========================================
- Hits           567       566    -1     
Flag Coverage Δ
unittests 99.29% <100.00%> (-0.01%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Contributor

@steven-murray steven-murray left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @piyanatk. This all looks good. My only comment is that I think we should split the methods at the module level, rather than the function-name level. I think this is better because it allows us to easily swap in different methods by just adding a new module. It is more along the lines of how other "drop-in replacement" libraries work (e.g. jax.numpy etc).

src/matvis/cli.py Outdated Show resolved Hide resolved
src/matvis/cpu.py Outdated Show resolved Hide resolved
@steven-murray
Copy link
Contributor

I think the GPU tests are failing either because the enterprise server is still down, or because it doesn't have this GLIBC library. I think we need @mkolopanis help on that.

Copy link
Contributor

@steven-murray steven-murray left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @piyanatk !

@steven-murray steven-murray merged commit e9a5a98 into main Nov 30, 2023
12 of 13 checks passed
@steven-murray steven-murray deleted the refactoring branch November 30, 2023 17:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants